[Webkit-unassigned] [Bug 39473] [DRT/Chromium] Link resources and load Ahem font for Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 21 03:06:34 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39473





--- Comment #8 from Kent Tamura <tkent at chromium.org>  2010-05-21 03:06:34 PST ---
(In reply to comment #5)
> > +    WCHAR ahemPath[_MAX_PATH];
> > +    struct _stat ahemStat;
> 
> Nit: Drop struct since it's not needed in C++.

Unfortunately, removing "struct" caused an error.  Probably because _stat is a function name too.

> > +    HANDLE h = ::AddFontMemResourceEx(fontBuffer, size, 0, &numFonts);
> 
> Nit: handle or fontHandle would be a more descriptive variable name.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list