[Webkit-unassigned] [Bug 39426] Calls to CallJNIMethodIDA() in JavaInstance::invokeMethod() are required on Android

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 21 01:51:11 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39426





--- Comment #3 from Steve Block <steveblock at google.com>  2010-05-21 01:51:10 PST ---
Thanks for the review Alexey.

> I would appreciate a more detailed explanation of the change. How is this a
> build fix?
Android has always used this code path, so adding the BUILDING_ON_TIGER guards broke the Android build. The android port is not yet fully upstreamed and we don't sync WebKit too frequently, so it took us a while to notice the break.

> Why are these calls required?
I'm not sure. I'm not too familiar with this code, but have filed Bug 39476 to track this.

I'll land the patch now so as to fix the build, but with an additional comment about the need to avoid the use of this deprecated code path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list