[Webkit-unassigned] [Bug 36359] Double clicking page's last editable inline element doesn't select a word.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36359





--- Comment #11 from MORITA Hajime <morrita at google.com>  2010-05-20 22:57:29 PST ---
Hi Ojan, thank you for reviewing!

> Doesn't previousBoundary have the same bug? Would be good to understand why it doesn't or to fix it and add a testcase for that as well. r- for the previousBoundary issue.
Yes. Although I've filed the case to Bug 36360, It would be better to tackle these to same patch
because they've caused from almost same problem, as you mentioned.
So I updated the patch to tackle both.
I'll close Bug 36360 after this patch is landed.

> 
> LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:45
>  +  function flushLog()
> This doesn't seem necessary since you only call log once in this test. You can move the logging logic into the log function.
Fixed.

> 
> LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:29
>  +      eventSender.leapForward(1);
> These leapForward calls are not necessary to test double-click selecting a word. Just the mouseMoveTo, mouseDown and mouseUp calls are needed.
Fixed.

> 
> LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:21
>  +      pos.y += target.clientHeight/2;
> nit: webkit style: there should be spaces around the /
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.