[Webkit-unassigned] [Bug 32077] textarea grows when you type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32077





--- Comment #31 from MORITA Hajime <morrita at google.com>  2010-05-20 22:40:04 PST ---
Kent-san, Hamaji-san, thank you for reviewing quickly.

(In reply to comment #27)
> (From update of attachment 56667 [details])
> The patch contains no test expectation files.
Oops. Added it. I'm sorry for that.

(In reply to comment #28)
> (From update of attachment 56667 [details])
> LayoutTests/fast/forms/script-tests/textarea-percentage-dimensions.js:29
>  +  \ No newline at end of file
Fixed.


(In reply to comment #29)
> (From update of attachment 56667 [details])
> LayoutTests/fast/forms/script-tests/textarea-percentage-dimensions.js:1
>  +  
> An unnecessary blank line?
Fixed.

> 
> WebCore/ChangeLog:12
>  +          its layout, but the this assumption get violated when the
> "the this" => "this" ?
Fixed.

> 
> WebCore/ChangeLog:11
>  +          is because calcHeight() assumes that their ancestors are during
> Not sure if it's OK as English. Maybe "calcHeight() assumes the existence of its ancestors during its layout"? Or, is the "their" different from "its"?
I agree that the description was confusing. I tried to clarify that part.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.