[Webkit-unassigned] [Bug 39440] [chromium] Adds Geolocation support to DumpRenderTree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39440


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56620|review?                     |review-
               Flag|                            |




--- Comment #2 from Kent Tamura <tkent at chromium.org>  2010-05-20 20:45:11 PST ---
(From update of attachment 56620)
Thank you for making the patch.
WebKitTools/DumpRenderTree/chromium is not the primary tester yet.  You need to change webkit/tools/test_shell/ in Chromium too.


WebKit/chromium/public/WebGeolocationServiceMock.h:55
 +      static bool m_mockGeolocationPermission;
We don't prepend "m_" for a static field in WebKit style.


WebKitTools/DumpRenderTree/chromium/LayoutTestController.cpp:1303
 +      WebGeolocationServiceMock::setMockGeolocationError(arguments[0].toInt32(), WebString::fromUTF8(arguments[1].toString()));
nit: We have cppVariantToWebString().


r- for the style error.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.