[Webkit-unassigned] [Bug 38324] [Qt] Fix compilation with QT_NO_FEATURE

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 20 18:52:47 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38324





--- Comment #23 from Tasuku Suzuki <tasuku.suzuki at nokia.com>  2010-05-20 18:52:45 PST ---
(In reply to comment #22)
> (From update of attachment 56562 [details])
> 
> I think the the above situation you should quard more code, as the code that follows the inspectorUrl = is not useful without an actual url.

Do you mean we should do like below?

-    QUrl inspectorUrl = inspector->property("_q_inspectorUrl").toUrl();
+    QUrl inspectorUrl;
+#ifndef QT_NO_PROPERTIES
+    inspectorUrl = inspector->property("_q_inspectorUrl").toUrl();
     if (!inspectorUrl.isValid())
+#endif
         inspectorUrl = QUrl("qrc:/webkit/inspector/inspector.html");
     inspectorView->page()->mainFrame()->load(inspectorUrl);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list