[Webkit-unassigned] [Bug 39456] [chromium] WebFrame::contentAsText should not return the text from hidden frames

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39456


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-05-20 17:17:40 PST ---
Attachment 56649 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
der this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/src/WebFrameImpl.cpp:239:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/tests/WebURLLoaderMock.h:48:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKit/chromium/tests/WebURLLoaderMock.h:67:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
WebKit/chromium/tests/WebURLLoaderMock.cpp:30:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/WebURLLoaderMock.cpp:34:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/WebURLLoaderMock.cpp:40:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/data/iframes_test.html:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/tests/data/invisible_iframe.html:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
WebKit/chromium/tests/WebURLLoaderMockFactory.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/WebURLLoaderMockFactory.h:35:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/WebURLLoaderMockFactory.h:57:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKit/chromium/tests/WebFrameTest.cpp:36:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/WebFrameTest.cpp:39:  Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit/chromium/tests/WebFrameTest.cpp:42:  Alphabetical sorting problem.  [build/include_order] [4]
WebKit/chromium/tests/WebFrameTest.cpp:55:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKit/chromium/tests/WebFrameTest.cpp:67:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/WebFrameTest.cpp:88:  This { should be at the end of the previous line  [whitespace/braces] [4]
WebKit/chromium/tests/WebFrameTest.cpp:107:  Use 0 instead of NULL.  [readability/null] [5]
WebKit/chromium/tests/data/zero_sized_iframe.html:1:  One or more unexpected \r (^M) found; better to use only a \n  [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 43 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.