[Webkit-unassigned] [Bug 39452] New: caller of scheduleLocationChange in V8 binding and generic binding used the wrong signature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39452

           Summary: caller of scheduleLocationChange in V8 binding and
                    generic binding used the wrong signature
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore JavaScript
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: klobag at gmail.com
                CC: android-webkit-unforking at google.com


Both V8 binding and generic binding assumes scheduleLocationChange() has four inputs. Here is the code snippet

            frame->redirectScheduler()->scheduleLocationChange(completedUrl, referrer, false, userGesture);

But it actually has five. See below. 

    void scheduleLocationChange(const String& url, const String& referrer, bool lockHistory = true, bool lockBackForwardList = true, bool userGesture = false);

This caused userGesture maps to lockBackForwardList and userGesture is always false.

Patch is coming.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.