[Webkit-unassigned] [Bug 36359] Double clicking page's last editable inline element doesn't select a word.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36359


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51710|review?                     |review-
               Flag|                            |




--- Comment #9 from Ojan Vafai <ojan at chromium.org>  2010-05-20 15:27:06 PST ---
(From update of attachment 51710)
Sorry the review took so long.

Doesn't previousBoundary have the same bug? Would be good to understand why it doesn't or to fix it and add a testcase for that as well. r- for the previousBoundary issue.

LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:45
 +  function flushLog()
This doesn't seem necessary since you only call log once in this test. You can move the logging logic into the log function.

LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:29
 +      eventSender.leapForward(1);
These leapForward calls are not necessary to test double-click selecting a word. Just the mouseMoveTo, mouseDown and mouseUp calls are needed.

LayoutTests/editing/selection/doubleclick-inline-last-contenteditable.html:21
 +      pos.y += target.clientHeight/2;
nit: webkit style: there should be spaces around the /

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.