[Webkit-unassigned] [Bug 39203] [DRT/Chromium] Increase the time out value

Thu May 20 14:25:20 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=39203

Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpranke at chromium.org

--- Comment #9 from Ojan Vafai <ojan at chromium.org>  2010-05-20 14:25:18 PST ---
Dirk is way more familiar with the current state of this code than I am.

(In reply to comment #4)
> It seems like the DRT timeout should be longer than the script timeout (just like how you mentioned it was 10 seconds vs 6 seconds for test_shell and the script).

I actually think it's the other way around. If DRT times out, then it can dump whatever results it has so far and then load the next test. If the script times out, all it can do is kill DRT.

new-run-webkit-tests passes the per-test timeout to test_shell when it's running the test, so that value isn't even used for new-run-webkit-tests.

(In reply to comment #3)
> (In reply to comment #2)
> > I'm a little confused.  I thought when we hit the timeout, we first call notifyDone, and if that fails, we exit(0) the process (which looks like a crash).  Is the call to notifyDone failing?
> 
> The problem is that, if a DRT process exits before new-run-webkit-tests detects timeout, new-run-webkit-tests assumes the DRT process crashed.

If this is true, it's a regression or it's a difference between DRT and test_shell. 

There are two timeout cases:
1. The test times out due to logic error (e.g., forgot to call notifyDone). In this case, DRT can just dump #TIMEOUT and load the next test.
2. The test times out because DRT is hung. In this case, DRT needs to be killed. test_shell has code to also dump #TIMEOUT here in the relevant signal handlers. Does DRT not?

#TIMEOUT lets new-run-webkit-tests know that the test timed out instead of crashing, even if DRT/test_shell disapears.

Anyways, this patch is fine. We should match Mac DRT. But, I think the underlying bug is still there.

Also, FWIW, the conclusion last time that we talked about timeouts on webkit-dev was that all tests would get a long (e.g. 30 seconds) timeout except for tests that are expected to timeout, which will get a much shorter timeout (e.g. a couple seconds). That way, we don't need to manually mark tests as SLOW and timeout tests don't make the test cycle time insanely large.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.