[Webkit-unassigned] [Bug 39288] Geolocation causes DOMWindow to leak if position requests are in progress when the page is navigated away

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39288


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56590|review?                     |review+
               Flag|                            |




--- Comment #11 from Darin Adler <darin at apple.com>  2010-05-20 11:31:26 PST ---
(From update of attachment 56590)
> +     // Stop the Geolocation object, if present. This call is made after the unload
> +     // event has fired, so no new Geolocation activity is possible.
> +    if (m_frame->domWindow()->navigator()->optionalGeolocation())
> +        m_frame->domWindow()->navigator()->optionalGeolocation()->stop();

Incorrect indentation of the comment here.

What about if some other frame in the same domain has access to this frame, and later tries to trigger some geolocation activity in this frame with JavaScript code?

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.