[Webkit-unassigned] [Bug 39206] [GStreamer] video painting support on mac port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39206


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56227|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Eric Carlson <eric.carlson at apple.com>  2010-05-20 09:45:21 PST ---
(From update of attachment 56227)
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * aint with this library; see the file COPYING.LIB.  If not, write to
>
This typo is back, "aint" should be "along" (see https://bugs.webkit.org/show_bug.cgi?id=36442).

> +    CGColorSpaceRef colorSpace = CGColorSpaceCreateDeviceRGB();
> +    CGImageRef frameImage = CGImageCreate(size.width(), size.height(), 8, 32, size.width()*4, colorSpace,
> +        kCGBitmapByteOrder32Little | kCGImageAlphaFirst, provider.get(), 0, false, kCGRenderingIntentDefault);
> +    m_image = BitmapImage::create(frameImage);
> +}
> 
You are leaking the CGColorSpaceRef. Since your frames are always in the same color space, you could use a static.

r=me with these changes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.