[Webkit-unassigned] [Bug 39210] Provide bindings for DeviceOrientation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39210





--- Comment #10 from Steve Block <steveblock at google.com>  2010-05-20 09:39:25 PST ---
> WebCore/Android.derived.v8bindings.mk:34
>  +  FEATURE_DEFINES += V8_BINDING
> Did you mean for this to be here?
Yes - I split this out onto its own line because it's not really a feature like the others are.

> WebCore/config.h:109
>  +  #define ENABLE_DEVICE_ORIENTATION 1
It doesn't really matter - removed for now.

> WebCore/dom/DeviceOrientationEvent.h:46
>  +      double alpha() { return m_alpha; }
> ) const {
Done

> LayoutTests/platform/gtk/Skipped:1182
>  +  fast/dom/DeviceOrientation/window-property.html
> Why not the whole directory?
That's what the comments at the top of this file require - 'no grouping should occur. Every test for itself'

> LayoutTests/platform/chromium/test_expectations.txt:2843
>  +  DEFER SKIP : fast/dom/DeviceOrientation = TEXT
> What's defer mean?
>From the comments as the top of the file - 'DEFER: For tests we'll fix in the future.'

> I made a bug for this.  s/DEFER/BUG44654/
Done

> WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:57
>  +          PerformEnvironmentSet="true"
> Is this supposed to be true?
All of the flags in this file seem to set this.

> WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:57
>  +          PerformEnvironmentSet="true"
> Is this supposed to be true?
Ditto

> LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js:5
>  +      for (var property in window) {
> Why not just 'if ('ondeviceorientation' in window)' ?
We already test this on line 14. The difference is that properties which are marked 'DontEnum' will pass 'if (foo in bar)' but won't be enumerated with 'for (var x in bar)'. This test is copied from fast/dom/Geolocation/resources/enabled.js

> LayoutTests/fast/dom/DeviceOrientation/script-tests/window-property.js:17
>  +  window.jsTestIsAsync = false;
> is this necessary?
No, fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.