[Webkit-unassigned] [Bug 39288] Geolocation causes DOMWindow to leak if position requests are in progress when the page is navigated away

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39288





--- Comment #7 from Steve Block <steveblock at google.com>  2010-05-20 05:40:45 PST ---
> If we’re calling m_frame->domWindow() you should not check it for 0.
Done

> Is there a guarantee that no new geolocation activity can start after a frame
> stops loading?
This call is made after the unload event has been sent, which is the last point at which JS can make new calls to Geolocation. This call removes all ongoing Geolocation requests and stops the service, so there's no further activity.

The reason that removing the ongoing requests in Geolocation::disconnectFrame() (as in my first patch) is insufficient, is that in the case of the Page being destroyed, disconnectFrame() is not called until the Frame has been destroyed. However, the Frame may not be destroyed if the Geolocation object still holds references to JS callback functions, as these create circular references.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.