[Webkit-unassigned] [Bug 38640] [Chromium] Suggestion popup is not closed when view is scrolled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38640





--- Comment #16 from Roman <romange at google.com>  2010-05-20 03:18:07 PST ---
(In reply to comment #14)
> > > > +    if (m_webView->client())
> > > > +        m_webView->hidePopups();
> > > 
> > > why do you need to null check client before calling hidePopups?
> > 
> > I am being consistent with the code around. The scroll() function null checks the client so I assumed I need to do this as well.
> 
> The null checks for m_webView->client() exist to avoid calling methods on a null m_webView->client().  It is not necessary in the case above since you are calling a method on m_webView.

Oops, I was under impression that I am using client() during the call. The fixed patch is uploaded.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.