[Webkit-unassigned] [Bug 39366] Move view-related functions from Frame to FrameView

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39366


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56500|review?                     |review+
               Flag|                            |




--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-05-20 00:51:52 PST ---
(From update of attachment 56500)
WebCore/css/CSSStyleSelector.cpp:4043
 +                          multiplier *= view->textZoomFactor();
much cleaner, thanks.

WebCore/dom/MouseRelatedEvent.cpp:137
 +      float zoomFactor = pageZoomFactor(this);
MUCH cleaner.  Thanks again!

WebCore/html/HTMLBodyElement.cpp:268
 +      document->updateLayoutIgnorePendingStylesheets();
This is a behavior change.  We didn't use to bother to layout when the view didn't exist.  Is this intentional?

WebCore/page/FrameView.h:297
 +      int m_borderX;
This is destined to be an IntSize in a later patch. :)

WebKit/efl/ewk/ewk_frame.cpp:974
 +          return -1;
-1?

LGTM.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.