[Webkit-unassigned] [Bug 39296] build-webkit doesn't recognize Platform SDK on win64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39296


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56535|review?                     |review+
               Flag|                            |




--- Comment #9 from Daniel Bates <dbates at webkit.org>  2010-05-19 17:58:46 PST ---
(From update of attachment 56535)
> -    return if -e $windowsPlatformSDKRegistryEntry;
> +    # FIXME It would be better to detect if this is a 64-bit Windows build
> +    # and only check the appropriate entry. But for now we just blindly check
> +    # both.

You are missing a ':' after FIXME in the comment, which is necessary for some editors, such as Xcode, to notice that this is a special comment.

Since the last line of this comment is only one word, I would suggest collapsing it into the second line and push the word "and" (at the start of the second line) into the first line so that the two lines are roughly the same size.

Also, I think it might be a bit clearer to write the first sentence as "It would be better to detect whether we are using 32-bit or 64-bit Windows ...":

# FIXME: It would be better to detect whether we are using 32- or 64-bit Windows
# and only check the appropriate entry. But for now we just blindly check both.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.