[Webkit-unassigned] [Bug 39146] [Qt] Pass all web notification layout tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39146





--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-05-19 11:24:07 PST ---
(From update of attachment 56493)

> +    enum NotificationPermission {
> +        PermissionAllowed,
> +        PermissionNotAllowed,
> +        PermissionDenied
> +    };

Maybe leave out Permission (we normally leave our or prepend part of the enum name)

What is the difference between NotAllowed and Denied? That is not obvious.

Are you sure this will never turn into a flag in the future?

Where are these used? I don't seem them used in the API.

> +
>      explicit QWebPage(QObject *parent = 0);
>      ~QWebPage();
>  
> @@ -258,6 +264,8 @@ public:
>  
>      QMenu *createStandardContextMenu();
>  
> +    void allowNotificationForOrigin(const QString& origin);

Origin makes me think of QWebSecurityOrigin, our other API's uses ForUrl (useAgentForUrl etc)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.