[Webkit-unassigned] [Bug 39296] build-webkit doesn't recognize Platform SDK on win64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39296





--- Comment #5 from Tony Gentilcore <tonyg at chromium.org>  2010-05-19 10:39:13 PST ---
(In reply to comment #3)
> (From update of attachment 56383 [details])
> 
> >  {
> >      my $windowsPlatformSDKRegistryEntry = "/proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/MicrosoftSDK/InstalledSDKs/D2FF9F89-8AA2-4373-8A31-C838BF4DBBE1";
> > +    my $windows64PlatformSDKRegistryEntry = "/proc/registry64/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/MicrosoftSDK/InstalledSDKs/D2FF9F89-8AA2-4373-8A31-C838BF4DBBE1";
> 
> Is there no way to detect that we are building Windows 64? 

I'm sure there is a way, but I'm not a windows environment or perl expert. I just had to run the layout tests on win and this got me building. I've added a FIXME comment.

> Also, these paths diff only in there prefix. It seems extraneous to repeat the value twice just because of the difference in prefix.

I've cleaned up that part.

> 
> >  
> > -    return if -e $windowsPlatformSDKRegistryEntry;
> > +    return if ((-e $windowsPlatformSDKRegistryEntry) || (-e $windows64PlatformSDKRegistryEntry));
> 
> I also agree with Adam Roben about omitting the outer parentheses here.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.