[Webkit-unassigned] [Bug 37291] Converting DOM timestamp -> X timestamp in plugin message is wrong
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 19 07:30:31 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=37291
--- Comment #19 from Kenneth Rohde Christiansen <kenneth at webkit.org> 2010-05-19 07:30:29 PST ---
(In reply to comment #18)
> (From update of attachment 56024 [details])
> This looks pretty good to me. I noticed in some places you call it "platformTime" and in others "platformTimeStamp", probably would be good to unify on one.
Yes, that can be changed, the other timestamp uses a variable called m_createTime, so I named it m_platformTime for consistance with this variable. No biggie though.
> Where is PlatformTimeStamp defined? It needs to be at least a "long" for X time, I think.
That was defined in PlatformEvent.h which I forgot adding to the diff at first, but then remembered and then uploaded the first diff :-) my bad!
It had the following define
+#if OS(LINUX)
+typedef unsigned long PlatformTimeStamp;
+#else
+typedef unsigned long long PlatformTimeStamp;
+#endif
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list