[Webkit-unassigned] [Bug 39318] Refactor HTMLTokenizer::write to make it more readable and split out the lexer bits from flow control bits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39318





--- Comment #12 from Eric Seidel <eric at webkit.org>  2010-05-18 23:06:46 PST ---
Ahha!  Wrote a new benchmark. :)

The new benchmark (soon to be attached to bug 39338) correctly shows that the orginal patch and the "inline" patch are both regressions.  But using ALWAYS_INLINE on the new function shows no change.


r59687 Release Build:

Running 20 times
Ignoring warm-up run (4184)
3700
3741
3784
3735
3726
3769
3823
3775
3770
3800
3888
3811
3859
3920
3864
3950
3997
3921
3987
4027

avg 3842.35
stdev 95.62231695582365

r59687 "inline" patch applied:

Running 20 times
Ignoring warm-up run (4447)
4000
4132
3981
4047
4048
4055
4130
4021
4105
4071
4120
4161
4133
4215
4127
4204
4148
4228
4171
4256

avg 4117.65
stdev 75.01484853014102

r59687 with ALWAYS_INLINE patch applied:

Running 20 times
Ignoring warm-up run (4130)
3690
3728
3776
3759
3732
3782
3843
3787
3786
3841
3910
3826
3878
3960
3876
3932
4020
3937
4015
4001

avg 3853.95
stdev 97.88435779020057

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.