[Webkit-unassigned] [Bug 34529] [CSSOM] issues with cssText and selectorText

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 20:31:12 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=34529





--- Comment #10 from Yuzo Fujishima <yuzo at google.com>  2010-05-18 20:31:12 PST ---
Simon, Darin,

Thank you for reviewing this.
I've changed to use Vector<UChar>. Please take another look.

(In reply to comment #7)
> (In reply to comment #6)
> > In general this looks good, but doing lots of String appends is inefficient. You should use StringBuilder instead.
> 
> Good point! But for building strings a character at a time, StringBuilder isn't efficient either. Vector<UChar> is probably the type of choice, or even Vector<UChar, 256>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list