[Webkit-unassigned] [Bug 39329] [WinCairo] Correct scaling for print preview

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39329





--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2010-05-18 18:33:45 PST ---
(From update of attachment 56425)
Brent asked me to do an informal review of this patch. I just have a couple
nits. Someone who knows a little bit more about Windows print preview and
printing should probably review this officially.

> +        * WebFrame.cpp:
> +        (WebFrame::drawHeader): Use pre-positioned context to simplify 
> +         tthis method.

'tthis' -> 'this' :)

> +static void setCairoToHDC(cairo_t* cr, HDC targetDC)

I think maybe this should have a more descriptive name as it touches
not only the Cairo context but the current world transform. Since this
patch is a work-around for a Cairo bug, maybe there should be a longish
comment at the call-site with a high-level overview of the problem (and
perhaps a link to the Cairo bug report, if it exists?).

This all looks pretty reasonable to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.