[Webkit-unassigned] [Bug 38640] [Chromium] Suggestion popup is not closed when view is scrolled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38640





--- Comment #14 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-05-18 12:57:50 PST ---
> > > +    if (m_webView->client())
> > > +        m_webView->hidePopups();
> > 
> > why do you need to null check client before calling hidePopups?
> 
> I am being consistent with the code around. The scroll() function null checks the client so I assumed I need to do this as well.

The null checks for m_webView->client() exist to avoid calling methods on a null m_webView->client().  It is not necessary in the case above since you are calling a method on m_webView.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.