[Webkit-unassigned] [Bug 39296] build-webkit doesn't recognize Platform SDK on win64

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39296





--- Comment #3 from Daniel Bates <dbates at webkit.org>  2010-05-18 12:46:52 PST ---
(From update of attachment 56383)

>  {
>      my $windowsPlatformSDKRegistryEntry = "/proc/registry/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/MicrosoftSDK/InstalledSDKs/D2FF9F89-8AA2-4373-8A31-C838BF4DBBE1";
> +    my $windows64PlatformSDKRegistryEntry = "/proc/registry64/HKEY_LOCAL_MACHINE/SOFTWARE/Microsoft/MicrosoftSDK/InstalledSDKs/D2FF9F89-8AA2-4373-8A31-C838BF4DBBE1";

Is there no way to detect that we are building Windows 64? Also, these paths diff only in there prefix. It seems extraneous to repeat the value twice just because of the difference in prefix.

>  
> -    return if -e $windowsPlatformSDKRegistryEntry;
> +    return if ((-e $windowsPlatformSDKRegistryEntry) || (-e $windows64PlatformSDKRegistryEntry));

I also agree with Adam Roben about omitting the outer parentheses here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.