[Webkit-unassigned] [Bug 39302] New: [Chromium] WebDevToolsAgentClient::sendMessageToFrontendOnIOThread needs to be implemented as virtual function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39302

           Summary: [Chromium]
                    WebDevToolsAgentClient::sendMessageToFrontendOnIOThrea
                    d needs to be implemented as virtual function
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit API
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: victorw at chromium.org
                CC: fishd at chromium.org, pfeldman at chromium.org,
                    yurys at chromium.org, victorw at chromium.org


Here is IORPCDelegate code in WebDevToolsAgentImpl.cpp:

class IORPCDelegate : public DevToolsRPC::Delegate, public Noncopyable {
public:
    IORPCDelegate() { }
    virtual ~IORPCDelegate() { }
    virtual void sendRpcMessage(const WebDevToolsMessageData& data)
    {
        WebDevToolsAgentClient::sendMessageToFrontendOnIOThread(data);
    }
};

WebDevToolsAgentClient::sendMessageToFrontendOnIOThread is implemented in chromium code base (devtools_agent.cc). This prevents us from building webkit as a dll. We should change sendMessageToFrontendOnIOThread to be a virtual function and access it through WebDevToolsAgentClient object.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.