[Webkit-unassigned] [Bug 38783] [chromium] Implement h/w accelerated compositing for LayerChromium layers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38783





--- Comment #12 from Vangelis Kokkevis <vangelis at chromium.org>  2010-05-18 11:10:49 PST ---
(In reply to comment #10)
> (From update of attachment 56297 [details])
> Overall, looks great.  Just a few minor issues:

Thanks for the quick review! Please see new patch.

> 
> WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:535
>  +      // The position of they layer is the center of quad.
> nit: "they layer" -> "the layer" ?
> 

Done.

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:264
>  +              // Scrolling works as follows: We render a quad with the current root layer contents
> nit: indent by 4 spaces instead of 8.  true, this means the
> body is not visually separate from the "|| (scrollDelta..."
> bit, but that's what webkit style would have you do.
> 

Done. 

> WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:359
>  +      std::map<LayerChromium*, unsigned int>::iterator textureId;
> webkit avoids the container classes from STL.  please use HashMap
> from WTF instead.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.