[Webkit-unassigned] [Bug 38232] REGRESSION: crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting in an empty li

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38232


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55199|review?                     |review+
               Flag|                            |




--- Comment #6 from Ojan Vafai <ojan at chromium.org>  2010-05-18 10:53:49 PST ---
(From update of attachment 55199)
This looks good. The old code was clearly violating an assert in splitTreeToNode. I would bet that an audit of call calls to splitTreeToNode would find other cases like this. I almost wonder if splitTreeToNode should just deal with this case (i.e. not split and just return the passed in Node), but I'm on the fence. This is certainly fine as a fix to the crash.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.