[Webkit-unassigned] [Bug 38711] DragData::asURL() shouldn't do file validity checks

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 18 09:34:35 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38711


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56326|review?                     |review+
               Flag|                            |




--- Comment #33 from Darin Adler <darin at apple.com>  2010-05-18 09:34:33 PST ---
(From update of attachment 56326)
> +        // The loader will do the right thing if the filename is invalid for one reason or another.
> +        url = ChromiumBridge::filePathToURL(fileName).string();

I think the reference to "the loader" here is confusing and unnecessary. The comment is more about the old code than it is about the code that remains and could be omitted entirely.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list