[Webkit-unassigned] [Bug 39290] [GTK] build error without JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39290





--- Comment #4 from Ryuan Choi <ryuan.choi at gmail.com>  2010-05-18 08:39:18 PST ---
(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=56373)
 --> (https://bugs.webkit.org/attachment.cgi?id=56373) [details] [details]
> > Patch
> 
> +#if ENABLE(JIT)
>      if (isHostFunction()) {
>          callData.native.function = nativeFunction();
>          return CallTypeHost;
>      }
> +#endif
> 
> Don't think this is the proper solution. nativeFunction was previously implemented in runtime/JSFunction.h as
> 
> NativeFunction nativeFunction()
> {
>     return *WTF::bitwise_cast<NativeFunction*>(m_data);
> }
> 
> and the call you surrounded with #if ENABLE(JIT) was already there and being called also for !ENABLE(JIT)

I don't know too much about JIT. Just I need solution because It was replaced as JIT related
in my poor reading, I think that isHostFunction() return false when JIT feature was disabled.

isHostFunction looks return true only in two cases.
one is NativeExecutable which is JIT related class, other is VPtrHackExecutable
but VPtrHackExecutable was simply used.

does we check CallTypeHost when JIT feature was disabled?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.