[Webkit-unassigned] [Bug 39004] Crash on SVG feLigthing effects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39004





--- Comment #5 from Dirk Schulze <krit at webkit.org>  2010-05-18 08:08:13 PST ---
(In reply to comment #4)
> Created an attachment (id=56367)
 --> (https://bugs.webkit.org/attachment.cgi?id=56367) [details]
> patch
> 
> Opinion?

What about the imageRect calculation of other effects? Isn't it possible to take the calculation of eg. GaussianBlur or ColorMatrix? :

    IntRect effectDrawingRect = calculateDrawingIntRect(m_in->scaledSubRegion());
    RefPtr<ImageData> srcImageData(m_in->resultImage()->getPremultipliedImageData(effectDrawingRect));
    CanvasPixelArray* srcPixelArray(srcImageData->data());

    IntRect imageRect(IntPoint(), resultImage()->size());
    PassRefPtr<ImageData> imageData(resultImage()->getUnmultipliedImageData(imageRect));
    PassRefPtr<CanvasPixelArray> srcPixelArray(imageData->data());

    ... <pixel manipulation> ...


    resultImage()->putPremultipliedImageData(srcImageData.get(), imageRect, IntPoint());

In my opinion all effects should use a similar calculation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.