[Webkit-unassigned] [Bug 39081] [chromium] Adds supports for layout tests using GeolocationServiceMock

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39081





--- Comment #8 from Marcus Bulach <bulach at chromium.org>  2010-05-18 05:12:20 PST ---
(In reply to comment #6)
> (From update of attachment 56071 [details])
> > so yes, it's just an intermediary proxy that sits between Geolocation and the embedder. it's all boiler plate code to adapt
> >  what the embedder expects to what the mock provides, and to inject in a Geolocation object.
> OK, got it, thanks
> 
> WebKit/chromium/src/WebGeolocationServiceMock.cpp:124
>  +  void WebGeolocationServiceMock::useGeolocationServiceMock()
> Do you need this method? The existing GeolocationServiceMock simply calls GeolocationService::useMock() from setPosition() and setError(). Could we do similarly and call setCustomMockFactory() from setMockGeolocationPosition() and setMockGeolocationError()? Is the additional call to GeolocationService::useMock() required?

hehe, yeah, tricky trade off between less API surface versus number of calls..

anyways: followed your suggestions, removed the method, and added calls to setCustomMockFactory() on both setMockGeolocationPosition/Error.

another look please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.