[Webkit-unassigned] [Bug 39269] [Chromium] Windows: Determinate progress bar should have glossy overlay

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39269


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56327|review?                     |review-
               Flag|                            |




--- Comment #3 from Kent Tamura <tkent at chromium.org>  2010-05-18 01:24:29 PST ---
(From update of attachment 56327)


WebCore/platform/chromium/ChromiumBridge.h:228
 +              GraphicsContext*, const IntRect& barRect, const IntRect& valueRect, bool determinate, double time);
The name "time" is unclear.  Maybe "secondsSinceEpoch"?


WebCore/rendering/RenderThemeChromiumWin.cpp:672
 +      // So here we can return arbitrary value.
The value must be greater than 0, not arbitrary.




WebKit/chromium/public/WebThemeEngine.h:81
 +          bool determinate, double time) {}
Ditto for "time"


WebKit/chromium/src/ChromiumBridge.cpp:683
 +      GraphicsContext* gc, const IntRect& barRect, const IntRect& valueRect, bool determinate, double time)
ditto.

WebKit/chromium/src/ChromiumBridge.cpp:686
 +          gc->platformContext()->canvas(), barRect, valueRect, determinate, time);
ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.