[Webkit-unassigned] [Bug 39212] ImageData.data should be a CanvasPixelArray object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39212





--- Comment #6 from Andreas Kling <andreas.kling at nokia.com>  2010-05-17 23:36:13 PST ---
(In reply to comment #5)
> On the assumption that you're wanting to make a CPA instance claim to be an instanceof CanvasPixelArray you'll just want to make the logic that creates a CPA specify use the prototype from the CanvasPixelArray constructor, and set the constructor property on the CPA appropriately.

Your assumption is correct. I'll update the patch once I wrap my head around it.

> That said, you clearly are not testing performance of your change -- even the most rudimentary tests would have shown a huge (if memory serves ~5-10x) regression in read/write access to the cpa data.

Indeed true, this was merely a first (rather naive) shot at getting a "correct" implementation. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.