[Webkit-unassigned] [Bug 39257] Chromium: new-run-webkit-httpd fails to setup_mount

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39257


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56314|review?                     |review-
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2010-05-17 22:13:23 PST ---
(From update of attachment 56314)
WebKitTools/Scripts/webkitpy/common/system/executive.py:268
 +          if not isinstance(args, list) and not isinstance(args, tuple):
I think assert(isinstance(args, list) or isinstance(args, tuple)) would be clearer.  ScriptError is generally used for when the script being run has a error.

WebKitTools/Scripts/webkitpy/common/system/executive_unittest.py:47
 +          self.assertRaises(ScriptError, executive.run_command, "echo")
This would be AssertionError then.

WebKitTools/Scripts/webkitpy/common/system/executive_unittest.py:49
 +          executive.run_command(["echo", "foo"])
Is this going to end up outputing "foo" on the console when test-webkitpy is run?

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:59
 +          setup_mount = port.path_from_chromium_base("third_party",
This will fail to run in a non-chromium environment.  Instead you should mock out path_from_chromium_base for the test, no?

r- because the test would fail from a normal webkit checkout.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.