[Webkit-unassigned] [Bug 39256] Make sure globalExec always has a correct scopechain

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39256





--- Comment #3 from Oliver Hunt <oliver at apple.com>  2010-05-17 20:04:21 PST ---
(In reply to comment #2)
> (From update of attachment 56310 [details])
> >  ExecState* JSGlobalObject::globalExec()
> >  {
> > -    return CallFrame::create(d()->globalCallFrame + RegisterFile::CallFrameHeaderSize);
> > +    ExecState* result = CallFrame::create(d()->globalCallFrame + RegisterFile::CallFrameHeaderSize);
> > +    ASSERT(d()->globalScopeChain.node());
> > +    result->init(0, 0, d()->globalScopeChain.node(), CallFrame::noCaller(), 0, 0, 0);
> > +    return result;
> >  }
> 
> This seems to add quite a bit of extra work to a function that used to just compute and return a pointer. Why is this better?

it's groundwork for future optimisations

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.