[Webkit-unassigned] [Bug 39257] Chromium: new-run-webkit-httpd fails to setup_mount

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39257


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56309|review?                     |review+
               Flag|                            |




--- Comment #5 from Eric Seidel <eric at webkit.org>  2010-05-17 20:01:10 PST ---
(From update of attachment 56309)
WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:47
 +                                expected_stdout="",
These default to "", so the explicit ="" are not needed.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:51
 +          orig_platform = sys.platform
I would have abstracted that code into some sort of setup/teardown function.  If we wanted to get fancy we could use python 2.5+ contextual objects and a with statement, but that's probably overkill.

WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:62
 +                                expected_stdout="",
Not needed, defaults to ""

LGTM otherwise.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.