[Webkit-unassigned] [Bug 38640] [Chromium] Suggestion popup is not closed when view is scrolled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 17 10:31:47 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38640





--- Comment #12 from Roman <romange at google.com>  2010-05-17 10:31:45 PST ---
(In reply to comment #11)
> (From update of attachment 56182 [details])
> > Index: src/ChromeClientImpl.cpp
> ...
> >  void ChromeClientImpl::invalidateContentsForSlowScroll(const IntRect& updateRect, bool immediate)
> >  {
> > +    if (m_webView->client())
> > +        m_webView->hidePopups();
> 
> why do you need to null check client before calling hidePopups?

I am being consistent with the code around. The scroll() function null checks the client so I assumed I need to do this as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list