[Webkit-unassigned] [Bug 39216] Hook Chromium's WebIndexedDatabaseImpl up to IndexedDatabaseImpl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39216





--- Comment #6 from Nate Chapin <japhet at chromium.org>  2010-05-17 10:05:33 PST ---
(From update of attachment 56245)
> -    virtual void open(const String& name, const String& description, bool modifyDatabase, PassRefPtr<IDBCallbacks>, Frame*, ExceptionCode&);
> +    virtual void open(const String& name, const String& description, bool modifyDatabase, PassRefPtr<IDBCallbacks>, const String& origin, Frame*, ExceptionCode&);

Here and a bunch of other places, you're passing around the origin as a String/WebString. It probably makes more sense to use SecurityOrigin/WebSecurityOrigin.

That was the main thing I saw, but I'm not terribly confident on my understanding of the Chromium API layering and organization, so fishd's opinion will be appreciated. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.