[Webkit-unassigned] [Bug 39222] New: V8 code generator does not add ENABLE guards around attribute getters and setters

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39222

           Summary: V8 code generator does not add ENABLE guards around
                    attribute getters and setters
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: steveblock at google.com


The V8 code generator does not add ENABLE guards around the static functions used to implement generated attribute getters and setters. This means that when a class has methods which are guarded by an enable flag, and that flag is disabled, the generated code will reference these methods without a guard, causing compile errors.

For example, if TOUCH_EVENTS are disabled, ontouchstartAttrGetter() in V8DOMWindow.cpp is generated without guards and calls DOMWindow::ontouchstart(), which is guarded by ENABLE(TOUCH_EVENTS)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.