[Webkit-unassigned] [Bug 39211] [Chromium] Windows: Speed of indeterminate progress bar should be constant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39211





--- Comment #6 from MORITA Hajime <morrita at google.com>  2010-05-17 04:00:41 PST ---
Hi kent-san, thank you for reviewing!

(In reply to comment #3)
> (From update of attachment 56229 [details])
> WebCore/rendering/RenderThemeChromiumWin.cpp:664
>  +  static const double progressAnimationNumFrames = 60;
> If this value is not used anymore, remove it.
Fixed.

> 
> 
> WebCore/rendering/RenderThemeChromiumWin.cpp:665
>  +  static const double progressIndeterminateOverlayDelta =  175;
> Could you add a comment why this value is 175 please?
> The symbol name wasn't clear to me at first glance.  I recommend to make it contain "DeltaPerFrame" or "PixelsPerFrame".
Fixed to rename it to progressIndeterminateOverlayPixelsPerSecond.

> 
> 
> WebCore/rendering/RenderThemeChromiumWin.cpp:667
>  +  static const int progressIndeterminateOverlayWidth = 120;
Fixed to remove underling blank line to indicate comment coverage.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.