[Webkit-unassigned] [Bug 39211] [Chromium] Windows: Speed of indeterminate progress bar should be constant

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39211


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56229|review?                     |review-
               Flag|                            |




--- Comment #3 from Kent Tamura <tkent at chromium.org>  2010-05-17 03:27:52 PST ---
(From update of attachment 56229)
WebCore/rendering/RenderThemeChromiumWin.cpp:664
 +  static const double progressAnimationNumFrames = 60;
If this value is not used anymore, remove it.


WebCore/rendering/RenderThemeChromiumWin.cpp:665
 +  static const double progressIndeterminateOverlayDelta =  175;
Could you add a comment why this value is 175 please?
The symbol name wasn't clear to me at first glance.  I recommend to make it contain "DeltaPerFrame" or "PixelsPerFrame".


WebCore/rendering/RenderThemeChromiumWin.cpp:667
 +  static const int progressIndeterminateOverlayWidth = 120;
ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.