[Webkit-unassigned] [Bug 38982] [Chromium] Support icon loading for <input type=file>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38982





--- Comment #4 from Kent Tamura <tkent at chromium.org>  2010-05-17 03:11:31 PST ---
(In reply to comment #3)
> (In reply to comment #2)
> > is there a reason why this needs to be a method on WebViewClient?
> > it seems more like a platform thing that wouldn't vary depending
> > on the WebView.  should this be part of WebKitClient instead?
> 
> Patch Set 1 of http://codereview.chromium.org/174318/show used WebKitClient, and I switched to WebViewClient in Patch Set 2.  I think I had difficulty in implementing asynchronous reply in resource_message_filter.cc.   I'll try to remember the reason...


- IconManager must run on the UI thread.
- We can't use the UI thread in a sync message handling. (Pointed out by jam, and [1] mentions it)
- So, we must use asynchronous request and response messages.

Probably I couldn't find a way to identify a destination of response messages in resource_message_filter.cc. It there a way to implement asynchronous message round-trip in resource_message_filter?


[1] http://www.chromium.org/developers/design-documents/inter-process-communication

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.