[Webkit-unassigned] [Bug 39207] New: webkit-patch upload needs to pass diff to check-webkit-style

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39207

           Summary: webkit-patch upload needs to pass diff to
                    check-webkit-style
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: mjs at apple.com, abarth at webkit.org, ojan at google.com,
                    levin at chromium.org, cjerdonek at webkit.org


webkit-patch upload needs to pass diff to check-webkit-style

Right now both webkit-patch and check-webkit-style compute their own copy of the current diff.  This is very expensive, especially under SVN.

We should pass the diff to check-webkit-style via stdin, we have it sitting in a string right there during the CheckStyle step.  All we need to do is call self.cached_lookup(state, "diff") and pass it as input= as part of run_command.  We obviously would have to teach check-webkit-style how to expect the diff over stdin, but that should be easy to do.

I expect this could be a very large speedup for webkit-patch users.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.