[Webkit-unassigned] [Bug 39184] Add support for parsing a SVN property

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39184


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56205|0                           |1
        is obsolete|                            |
  Attachment #56205|review?                     |
               Flag|                            |
  Attachment #56212|                            |review?
               Flag|                            |




--- Comment #7 from Daniel Bates <dbates at webkit.org>  2010-05-16 22:21:03 PST ---
Created an attachment (id=56212)
 --> (https://bugs.webkit.org/attachment.cgi?id=56212)
Patch with unit tests

Spoke with Chris tonight, and we decided to change the line "if ($propertyChangeDelta == -1 * $expectedChangeDelta)" to  "if ($expectedChangeDelta && $propertyChangeDelta != $expectedChangeDelta)" to make it clearer to a reader that we should only die if the property change type (e.g. "Added") differs from the property value type (e.g. "+"), for "Added" and "Deleted" change types only.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.