[Webkit-unassigned] [Bug 39175] Properly handle invalid arguments to CanvasRenderingContext2D's getImageData() and putImageData()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39175


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56185|review?                     |review+
               Flag|                            |




--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-05-16 09:11:27 PST ---
(From update of attachment 56185)
> +
> +    if (!isfinite(sx) || !isfinite(sy) || !isfinite(sw) || !isfinite(sh)) {
> +        ec = NOT_SUPPORTED_ERR;
> +        return 0;
> +    }
> +
> +    if (!sw || !sh) {
> +        ec = INDEX_SIZE_ERR;
> +        return 0;
> +    }

Doesnt it make sense to put this test before the first one? I mean check !sw before !isfinite(sh) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.