[Webkit-unassigned] [Bug 38640] [Chromium] Suggestion popup is not closed when view is scrolled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38640





--- Comment #5 from Jeremy Moskovich <playmobil at google.com>  2010-05-16 01:22:34 PST ---
(From update of attachment 55983)
Informal review:

Changelogs:
 +          
I think your editor is stripping trailing whitespaces from files, I don't think you want to do that for the changelog, the diff should only contain your additions.

if (m_webView->client()) {
WebKit coding style is no curly braces for one line ifs.

void ChromeClientImpl::scroll(
I'd move the call to hidePopups() to before the dx,dy variable definitions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.