[Webkit-unassigned] [Bug 38957] scm.py should use self.run instead of run_command

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 14 23:23:19 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=38957





--- Comment #3 from Adam Barth <abarth at webkit.org>  2010-05-14 23:23:19 PST ---
> Do you just want **kwargs?  Or do you want to manage the default values explicitly?

Future patches will make run smarter to handle the args.  It's possible we'll want **kwargs at some point though.

> Why not just use Executive() now anyway?  No need to add more clients to the raw version, then we have less to import to this file anyway. :)

I'll do that in a future patch.  I just want to take it slow.

> By use Executive() i mean just create one here locally, even if it's not stored on self. yet.

I understand.

> r=me assuming your intent was not to change behavior.  Please consider the above comments.

Thanks for the comments.  Sorry I'm ignoring all of them.  :P

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list