[Webkit-unassigned] [Bug 19946] Possible misalignment in RenderArena when compiled for debug

Fri May 14 09:02:36 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=19946

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56070|review?                     |review+
               Flag|                            |

--- Comment #10 from Darin Adler <darin at apple.com>  2010-05-14 09:02:36 PST ---
(From update of attachment 56070)
> +#include <wtf/FastMalloc.h>
> +#include <wtf/Platform.h>

Since FastMalloc.h already includes Platform.h, there is no need to include Platform.h here.

> +#ifdef WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER
> +#define ARENA_ALIGN_MASK (sizeof(WTF::AllocAlignmentInteger) - 1)
> +#else
>  #define ARENA_ALIGN_MASK 3
> +#endif

I think it would be good eventually to get rid of WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER and always do this. A FIXME mentioning that would be a plus.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.