[Webkit-unassigned] [Bug 37602] AppCache Progress Events - need to include additional info per the spec

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37602





--- Comment #3 from Michael Nordman <michaeln at google.com>  2010-05-13 15:41:12 PST ---
Hi Patrick!

Something that you'll need to get this patch accepted is a layout test that verifies the new behavior. The appcache related layout tests can be found at.
  WebKit\LayoutTests\http\tests\appcache\...

Also I want to point out a second implementation of ApplicationCacheHost.cpp that is also in the code base.
  WebKit\chromium\src\ApplicationCacheHost.cpp

This second impl is also defined by the .h file that's in your patch. There's one edit in the .h file that will bust the chromium build.
  Vector<RefPtr<Event> > m_deferredEvents;


If you would be so kind as to retain the existing data members for us until we can catch up, that would be great... ala something like...

        DOMApplicationCache* m_domApplicationCache;
        DocumentLoader* m_documentLoader;

#if PLATFORM(CHROMIUM)
        friend class ApplicationCacheHostInternal;
        bool m_defersEvents; // Events are deferred until after document onload.
        Vector<EventID> m_deferredEvents;
        OwnPtr<ApplicationCacheHostInternal> m_internal;
#else
        friend class ApplicationCacheGroup;
        ... 
        bool m_defersEvents; // Events are deferred until after document onload.
        Vector<RefPtr<Event> > m_deferredEvents;

        // The application cache that the document loader is associated with (if any).
        RefPtr<ApplicationCache> m_applicationCache;
        ... etc ....
#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.